[WIP] VXEdDSA - Githubissues

coniks-sys / coniks-go

A CONIKS implementation in Golang

http://coniks.org

Other

116 stars 30 forks source link

[WIP] VXEdDSA #167

Open liamsi opened 7 years ago

liamsi commented 7 years ago

resolves #128 working version; still needs some cleanup:

[ ] use cached public-key
[ ] cleanup ed25519 package (unexport funcs, keep only one elligator2 implementation, test-vectors for elligator)
[ ] adopt to google's keytransparency vrf interface (?)
[ ] asserts
[ ] increase code readability (and make it more golang idiomatic)
[ ] TODOs, XXXs

aarshkshah1992 commented 5 years ago

Hey guys,

This looks like great work. Any plans to merge this ?

vqhuy commented 5 years ago

Hi, I'm afraid that we don't have any plan to merge this soon. In the meantime, you can merge it on your own fork if you want ;)

aarshkshah1992 commented 5 years ago

Thanks vqhuy. May I ask why there are no plans to merge this ? Do you need a developer to help clean this up before it is merged ?

vqhuy commented 5 years ago

Do you need a developer to help clean this up before it is merged ?

Yes, you are more than welcome. You might want to take a look at this list, especially the VRF interface.

/cc @Liamsi.

aarshkshah1992 commented 5 years ago

@Liamsi Thanks for the awesome work. I'd like to take this forward. Please can you elaborate a bit on these points of your checklist

1) Use cached Public key 2) Asserts

Also, would you be willing to review this once it is done ?

liamsi commented 5 years ago

@Liamsi Thanks for the awesome work. I'd like to take this forward. Please can you elaborate a bit on these points of your checklist

Unfortunately, I do not remember off the top of my head what those points on the checklist mean in detail. I'd need to look into the code (this implementation and the whispersystem C code) to understand what I was planning 🙈

Also, would you be willing to review this once it is done ?

Yes, of course! I'd be happy to review this!