Create generic interface for hash functions

coniks-sys / coniks-go

A CONIKS implementation in Golang

http://coniks.org

Other

116 stars 30 forks source link

Create generic interface for hash functions #178

Open vqhuy opened 7 years ago

vqhuy commented 7 years ago

Create PADHasher & TreeHasher interface to allow developers to use their own hash function.

Change the default hash function to SHA512/256

Part of #50 and #177

In favor of https://github.com/google/trillian/pull/694, I implemented 29aa6a2b46cc706d0741900b53d39ee38e1f33ac. Please let me know what you think.

gdbelvin commented 7 years ago

Would there be any interest in trying to syncronize this interface with the one in google/trillian#670 ?

liamsi commented 7 years ago

I like @gdbelvin's idea. It makes it easier to sync up and might increase compatibility. Be aware that the interface described in google/trillian#670 isn't fully implemented yet (but will be soon).

vqhuy commented 7 years ago

Would there be any interest in trying to syncronize this interface with the one in google/trillian#670 ?

Definitely.

gdbelvin commented 7 years ago

Glad to see this PR moving forward! Thanks @Liamsi and @c633. I'll ask the Trillian team if we can use a [32]byte under the hood for consistency. Perhaps we can get some test vectors for cross verification?

vqhuy commented 7 years ago

Perhaps we can get some test vectors for cross verification?

We would love to do that.