search

coniks-sys / coniks-go

A CONIKS implementation in Golang
http://coniks.org
Other
116 stars 30 forks source link

/protocol organizational refactoring #183

Closed vqhuy closed 6 years ago

vqhuy commented 6 years ago

Merge #170 & #182 first.

masomel commented 6 years ago

@c633 I went ahead and moved around the new test cases I added in #182 to make the tests pass again. There are, however, two tests in consistency_checks.go that no longer pass (TestVerifyRegistrationWithTB and TestVerifyFulfilledPromise). I don't know if you encountered this issue before.

vqhuy commented 6 years ago

Our error codes are a mess for now. Another PR will follow up.

vqhuy commented 6 years ago

All tests are fixed. PTAL.

vqhuy commented 6 years ago

Are we going to go back to using import . for the test cases that used to have cyclical dependencies?

I think yes.

masomel commented 6 years ago

In the spirit of refactoring: Is there an application layer API that we can refactor from the CLIs? I haven't spent much time looking into this, but it could be useful to have an application layer API for each component in the same way that we have a protocol level API for each. This could then help developers integrate things like a client with their existing applications. What do you think?

vqhuy commented 6 years ago

Is there an application layer API that we can refactor from the CLIs?

Yes, it is. Actually, every module that doesn't belong to cli package should be used to provide APIs for developers. We do have plan for this, please see #101, I think it belongs to milestone 0.3 and 0.5.