Refactor CLI packages - Githubissues

coniks-sys / coniks-go

A CONIKS implementation in Golang

http://coniks.org

Other

116 stars 30 forks source link

Refactor CLI packages #195

Closed masomel closed 6 years ago

masomel commented 6 years ago

Addresses #194

This PR moves the cli binaries to /cli and refactors some common functionality used to implement various CONIKS executables or client applications in the /application package.

[X] refactor encoding
[x] refactor common server functionality
[x] refactor server listener
[x] move logger from utils to application
[x] refactor bot
[x] refactor common CLI cmds
[X] refactor configs
[x] refactor CLI tools

liamsi commented 6 years ago

Closing and reopening to trigger travis ...

masomel commented 6 years ago

@c633 When you get a chance, can you please review?

vqhuy commented 6 years ago

I love what you did with cli packages. I have only a concern regarding the ServerBase exported APIs.