coniks-sys / coniks-go

A CONIKS implementation in Golang
http://coniks.org
Other
116 stars 30 forks source link

quick question on GetKey() #208

Closed weikengchen closed 6 years ago

weikengchen commented 6 years ago

I see that the GetKey function is discarded, yet the Lookup and HandleResponse still use it, causing all Lookup requests to return empty.

Besides, the initial running of the client will fail because the initial a.verifiedSTR is nil. #196

Do you have a history version of CONIKS where everything is working?

weikengchen commented 6 years ago

I think I should close this issue myself.

The authors have mentioned to use tagged release. https://github.com/coniks-sys/coniks-go/releases

I would suggest you to switch WIP into another repo under coniks-sys. And make coniks-go master to be a working version, therefore people can run the same go get to run your system.

vqhuy commented 6 years ago

@weikengchen Thank you for the suggestion. coniks-go is still under development, thus we propose people to use tagged releases when they want a stable, work out-of-the-box version, and keep master branch for developers and potential contributors.

weikengchen commented 6 years ago

Coniks is a very important project. Just feels that you may be a little bit busy and the last commit is several months ago :)

I use Coniks's Key Transparency as a tool for my course project. It runs well. I added a keylookup socket proxy for my project.

Hopes you have a success refactoring 👍

Deadlines of the course project approaching. Sorry for not being able to help contribute at this moment. Might come back here to contribute

masomel commented 6 years ago

Hi @weikengchen! We do appreciate your interest, and I'm so happy to hear you're using CONIKS in your course project :) As you may have seen on our website, this repo is maintained in part by two current graduate students (myself being one of them), so sadly, sometimes we have to shift our priorities away from CONIKS development for longer periods of time.

But we are planning to resume development this summer, and we'll keep the community in the loop more about our plans. If you're interested/available to contribute after your classes are done, please reach out to us and we can discuss potential issues/PRs.

weikengchen commented 6 years ago

Understood. I am also working on a long-term systems security project and know usually people can only focus on one thing.

Will do.