Doesn't build currently

liamsi commented 8 years ago

The project currently doesn't compile as it is:

syntax error in: https://github.com/citp/coniks-ref-implementation/blob/master/coniks_server/src/org/coniks/coniks_server/UserInfoChanges.java#L62 (can send you a PR for that)
something is wrong with the mixture of proto files, generated Java code, and the provided classes, for instance the field unknownFields in Hash isn't defined anywhere (not in the generated class nor in the underlying com.google.protobuf classes). Can you compile it locally?

masomel commented 8 years ago

I merged the key change code in, but I haven't gotten around testing it yet (hence why issues #2 and #3 haven't been closed yet). So thank you for pointing out these problems!

If you could send a PR for the syntax error, that would be great. As for the proto files, I already compiled them locally, and that is the generated Java that is in here right now. I'm not really sure what you're seeing. I'll have to investigate this as part of my testing.

masomel commented 8 years ago

Closing this issue since there's a separate issue for the broken protos.

liamsi commented 8 years ago

Thanks for your quick reply.

coniks-sys / coniks-java

Doesn't build currently #8