conjurdemos / conjur-intro

Miscellaneous utilities that make it easier to make, manage, and run demos
Apache License 2.0
10 stars 11 forks source link

Fix broken validating packages scripts #78

Closed JakeQuilty closed 3 years ago

JakeQuilty commented 4 years ago

I am also wondering if we should put the start, install, and it's own docker-compose.yml in separate directory since it doesn't get used anywhere else

jvanderhoof commented 4 years ago

@JakeQuilty, mind moving the install script into the bin directory? It should have gotten moved, but I didn't realize anyone used the install script 😛 .

It's likely beyond the scope of this PR, but we should get rid of the start script from the root (mental note on my part).

JakeQuilty commented 3 years ago

@jvanderhoof I added your suggestions. I deleted the /start script, because I looked around and it wasn't being used anywhere else

JakeQuilty commented 3 years ago

Sorry I took so long to finish this. I was using a modified version of one of the scripts for a different issue I was working on, so I waited until I was finished with that to make these changes