Closed diverdane closed 4 years ago
@Kumbi, thanks for the review!
configure_conjur_cli
function so that it's always runensure_conjur_cli_initialized
I did this to make things more robust. There were times when I had
environment variables messed up, and the Conjur CLI pod got created
but initialization failed at first. Fixing the env variable and re-running
the script didn't work with the prior code, because the initialization was
getting called conditionally: only when the Conjur CLI pod was created.
Now it's always run, and it's okay if this gets called when the pod is already
initialized.sed
with either Yaml.sh
or Helm charts
(wherever that's possible):
https://github.com/conjurdemos/kubernetes-conjur-demo/issues/113For some reason the build is currently failing...
For the life of me, I can't figure out why this failed. Just before the point of failure, the conjur-master-ext
service is created:
[2020-10-20T19:49:01.750Z] ++++++++++++++++++++++++++++++++++++++
[2020-10-20T19:49:01.750Z]
[2020-10-20T19:49:01.750Z] Creating load balancer for master and standbys.
[2020-10-20T19:49:01.750Z]
[2020-10-20T19:49:01.750Z] ++++++++++++++++++++++++++++++++++++++
[2020-10-20T19:49:02.696Z] service/conjur-master-ext created
But then moments later, there's an error revolving around this service not existing:
[2020-10-20T19:49:03.723Z] ++++++++++++++++++++++++++++++++++++++
[2020-10-20T19:49:03.723Z]
[2020-10-20T19:49:03.723Z] Configuring master pod.
[2020-10-20T19:49:03.723Z]
[2020-10-20T19:49:03.723Z] ++++++++++++++++++++++++++++++++++++++
[2020-10-20T19:49:03.981Z] pod/conjur-cluster-569f787bdb-86kxd labeled
[2020-10-20T19:49:04.241Z] error: you need to provide a route port via --port when exposing a non-existent service
I looked to see that all of the parallel OpenShift CI tests that are happening are using their own projects (namespaces), and they definitely are, so it's not being caused by deletion of a project/namespace by another parallel test.
I'm going to re-run the tests.
@kumbi, I made a stab at making sure that these scripts are backwards-compatible with other repos that use these scripts and make use of the DEPLOY_MASTER_CLUSTER
env variable. Details are in my comments above. Please take a look and let me know if there's a better way.
This change includes:
Addresses Issue #106, Issue #92, and Issue #108