conjurdemos / kubernetes-conjur-demo

Demo application for Conjur Kubernetes integration
11 stars 14 forks source link

Replace use of sed for yaml templating with Yaml.sh or helm charts #113

Open diverdane opened 3 years ago

diverdane commented 3 years ago

Is your feature request related to a problem? Please describe.

Several of the scripts in this repo make use of sed to replace templated fields in YAML files. For example, here's an example field replacement using sed:

```
sed "s#{{ CONJUR_ACCOUNT }}#$CONJUR_ACCOUNT#g"
```

The scripts that use sed for this purpose include:

This templating solution is difficult to follow and maintain. It would be better to replace these uses of sed with either:

Note: this suggestion came up during review for PR #107.

Describe the solution you would like

Helm charts are used wherever possible. Or, for cases such as policy templating, use Yaml.sh.

Describe alternatives you have considered

Additional context

This suggestion came up during review for PR #107.