conjurdemos / kubernetes-conjur-demo

Demo application for Conjur Kubernetes integration
11 stars 14 forks source link

Add OPENSHIFT_VERSION to test environments #123

Closed micahlee closed 3 years ago

micahlee commented 3 years ago

The kubernetes-conjur-deploy project now expects this environment variable to determine how it should deploy the Conjur or DAP server to test against. This allows it to account for changes from OC 3 to OC 4.

See: https://github.com/cyberark/kubernetes-conjur-deploy/pull/163

Connected to https://github.com/conjurinc/appliance/issues/1486

izgeri commented 3 years ago

can the TEST_PLATFORM vars be removed too?

micahlee commented 3 years ago

can the TEST_PLATFORM vars be removed too?

@izgeri It looks like it's still used here to switch between OCP and GKE: https://github.com/conjurdemos/kubernetes-conjur-demo/blob/master/ci/test#L182