conjurdemos / kubernetes-conjur-demo

Demo application for Conjur Kubernetes integration
11 stars 14 forks source link

Eliminates hanging on namespace deletion for OpenShift 4.3 #126

Closed diverdane closed 3 years ago

diverdane commented 3 years ago

This change adds:

NOTE: Jenkins tests are currently failing on OpenShift 4.5. This failure is unrelated to the change being made here. The failures for OpenShift 4.5 appear could possibly be due to improper credentials being set for this routine in platform_login:

  elif [[ "$PLATFORM" = "openshift" ]]; then
    oc login $OPENSHIFT_URL \
      --username=$OPENSHIFT_USERNAME \
      --password=$OPENSHIFT_PASSWORD \
      --insecure-skip-tls-verify=true
    docker login \
      -u _ -p "$(oc whoami -t)" \
      $DOCKER_REGISTRY_PATH
  fi

Addresses Issue #125

diverdane commented 3 years ago

@hughsaunders agreed, removing finalizers is brute-force-ish, since we're removing ALL finalizers. Perhaps a little more well-behaved workaround would be to run the oc namespace delete --timeout ...., let it time out, and then remove residual finalizers. But, this would add 10 minutes to each run (based on the timeout value).

diverdane commented 3 years ago

approved, don't forget to change the branch in the git clone command

@orenbm thanks, I removed the clone of the temporary branch, since the cyberark/kubernetes-conjur-deploy change has been merged.