conjurdemos / kubernetes-conjur-demo

Demo application for Conjur Kubernetes integration
11 stars 14 forks source link

Scripts fail when CONJUR_OSS_HELM_RELEASE_NAME is not set #133

Closed diverdane closed 3 years ago

diverdane commented 3 years ago

Summary

The scripts currently require that the environment variable CONJUR_OSS_HELM_RELEASE be set. This environment variable is set in our CI test scripts, but typical users of these scripts would not be aware that this setting is required.

The symptom is that if you run the scripts without setting this environment variable, you would see:

Retrieving Conjur certificate.
./5_app_store_conjur_cert.sh: line 14: CONJUR_OSS_HELM_RELEASE_NAME: unbound variable

Summarizing this issue:

Steps to Reproduce

Steps to reproduce the behavior:

Expected Results

See Summary above.

Actual Results (including error logs, if applicable)

See symptom described in the Summary above.

Reproducible

Version/Tag number

What version of the product are you running? Any version info that you can share is helpful. For example, you might give the version from Docker logs, the Docker tag, a specific download URL, the output of the /info route, etc.

Environment setup

Can you describe the environment in which this product is running? Is it running on a VM / in a container / in a cloud? Which cloud provider? Which container orchestrator (including version)? The more info you can share about your runtime environment, the better we may be able to reproduce the issue.

Additional Information

Add any other context about the problem here.

diverdane commented 3 years ago

Closing, since this was addressed by PR #134 .