Conjure plus - Githubissues

conjure-cp / conjure-notebook

3 stars 2 forks source link

Conjure plus #31

Closed ogabek96 closed 11 months ago

ogabek96 commented 1 year ago

Added %%conjure+ magic:

%%conjure+ stores previous runs and it is used for incremental model building
%%conjure magic is changed to run the model always from the beginning

ozgurakgun commented 1 year ago

Why did you close this PR @ogabek96?

ozgurakgun commented 1 year ago

so register_magic_function let's you set a magic_name that isn't necessarily a valid python identifier. good find! I remember we couldn't figure this out during your project or else conjure_settings would probably have been called conjure-settings!

ozgurakgun commented 1 year ago

The tests need updating, of course.

ogabek96 commented 1 year ago

so register_magic_function let's you set a magic_name that isn't necessarily a valid python identifier. good find! I remember we could figure this out during your project or else conjure_settings would probably have been called conjure-settings!

Why did you close this PR @ogabek96? It wasn't ready to merge, so I closed. We can leave it open if it okay

ozgurakgun commented 1 year ago

Yes, let's keep it open please.

ozgurakgun commented 12 months ago

Hi @ogabek96 - I just remembered this. What did you want to do before merging this? Do you mind if I continue working on adding this if you don't have the time?

ogabek96 commented 12 months ago

Didn't have a chance to work on this. I think there are only updating tests left in this PR. Yeah you can continue on this if you want

ozgurakgun commented 11 months ago

Closed, see #33