Error: Malformed JSON in a cached Essence Prime model

stylpe commented 2 years ago

Got this error, and it seems like there's two things wrong with Conjure's output:

/\ and \/ have unescaped backslashes.
Conjure actually writes data that doesn't conform to its own schema, see 7th entry in trailRewrites array, the "rule" is an array, but must be a string to be read back in. Manually joining the string with \n resolves the issue, so I would suggest that as a solution.

See https://replit.com/@SuperMikal/Conjure-and-Essence-20220507#feedback/bad-json/stdout and the model in the same folder.

stylpe commented 2 years ago

Would I be right in guessing https://github.com/conjure-cp/conjure/commit/5bbace8a8e2826aa35c33561ebbca2bcf657560c is where I would need to look to contribute a fix for this?

ozgurakgun commented 2 years ago

looks like it, thanks!

stylpe commented 2 years ago

I had some time (finally) to look at this again, and it looks like I forgot some important parameters to actually reproduce the bug in the test, so while the CI might pass now, it's not ready after all :P

conjure-cp / conjure

Error: Malformed JSON in a cached Essence Prime model #517