conjure-cp / conjure

Conjure: The Automated Constraint Modelling Tool
Other
96 stars 20 forks source link

update Z3 version, remove implicit dependency on Python 2 for build #526

Closed ott2 closed 2 years ago

ott2 commented 2 years ago
  1. Update z3 to 4.11.2 (was 4.8.8) and refactored to use version only in one place. In future the desired version numbers could perhaps be read from a configuration file?
  2. Now tries to use python3 if python is not found. I am not sure this works on all platforms we target as it needs which to be in the path (this is /usr/bin/which on macOS). Another solution is probably more elegant, this was the first reasonable one I found.
ozgurakgun commented 2 years ago
  1. not sure about this. I like having the scripts self contained like this, but feel free to propose improvements of course.
  2. I like it!

the CI failed due to OOM, I kicked it to try again.