search

conjure-cp / conjure

Conjure: The Automated Constraint Modelling Tool
Other
96 stars 24 forks source link

replace which by command as per POSIX #531

Closed ott2 closed 2 years ago

ott2 commented 2 years ago

This replaces my previous use of which by command -v in the Python detection code as per https://stackoverflow.com/questions/592620/how-can-i-check-if-a-program-exists-from-a-bash-script to hopefully make the Z3 build more portable.

ozgurakgun commented 2 years ago

Thanks!

ozgurakgun commented 2 years ago

Hi @ott2. One of these 2 documentation PRs seems to have broken read the docs.

It says:

Exception occurred:
  File "/home/docs/checkouts/readthedocs.org/user_builds/conjure/envs/latest/lib/python3.7/site-packages/pygments/__init__.py", line 45, in lex
    raise TypeError('lex() argument must be a lexer instance, '
TypeError: lex() argument must be a lexer instance, not a class

Not sure if this is a Sphinx version issue? Any ideas?

ott2 commented 2 years ago

This looks like a Sphinx version issue, indeed. The old Sphinx has a different API here. Can one specify the Python environment in more detail for readthedocs?

ozgurakgun commented 2 years ago

It should be pulling versions from the requirements.txt file.

ozgurakgun commented 2 years ago

This seems to have fixed it. Thanks Andras!