search

conjure-cp / conjure

Conjure: The Automated Constraint Modelling Tool
Other
94 stars 20 forks source link

Fix regression in how we handle solution copying #570

Closed ozgurakgun closed 1 year ago

ozgurakgun commented 1 year ago

Fix regression in how we handle solution copying. This only effected parameter files that had dashes (-) in the filename. Added a regression test case as well. Thanks @ott2 for reporting!

ozgurakgun commented 1 year ago

This seems to work now @ott2. I'll merge soon, but feel free to take a look at the diff before I do so? I might be missing something again...

ott2 commented 1 year ago

@ozgurakgun Not sure this is the precise same issue, but current head has this solution copying problem if one specifies a pathname for a parameter file that includes a directory separator: conjure solve tmp/test.essence tmp/test.param fails to copy the solution file, whereas conjure solve tmp/test1.essence works fine, with an unparameterised spec.

Edit: in case this has a different cause, have opened a new issue #578 about this.