Closed N-J-Martin closed 10 months ago
Looks good! Except we probably don't want the docs/notebooks/division_n_fractions.ipynb:Zone.Identifier
file, right?
also, just general git feedback. it looks like you were using the main branch of your fork, in the future it might make more sense to make a branch inside your fork so you are not working on main. not a problem for this PR though.
Looks good! Except we probably don't want the
docs/notebooks/division_n_fractions.ipynb:Zone.Identifier
file, right?
I'm not entirely sure what that is, I think it got added when I moved the ipynb into there. I don't know how important it is?
Quick googling: https://stackoverflow.com/questions/4496697/what-are-zone-identifier-files-and-how-do-i-prevent-them-from-being-created
I think they are probably useful when you are running the notebook but we shouldn't commit them to the repo.
Hi @N-J-Martin - if you can remove the extra file I can merge this and we can see it in action.
I removed that extra identifier file, and added another notebook and completed the L_div.md page. Can you see those updates?
I'll merge as is so we can see in the VS Code extension. The links to the notebooks aren't Colab links as far as I can see, we should fix those.
Just added the n-fractions notebook and added link to the div.md page. Mostly trying this out.