conjure-cp / conjure

Conjure: The Automated Constraint Modelling Tool
Other
94 stars 20 forks source link

Fixed typo from PR #598 and documentation bits for set operators #599

Closed N-J-Martin closed 9 months ago

N-J-Martin commented 9 months ago

found a mistake in the links for the this notebook, should be corrected now @hz66-404 is welcome to have another look to be sure I caught everything!

ozgurakgun commented 9 months ago

OK, I'll wait until @hz66-404 has a chance to take a look. Thanks!

hz66-404 commented 9 months ago

Thanks! Just a small issue, can you modify the L_Plus heading to a single #

N-J-Martin commented 9 months ago

It is like that now?

hz66-404 commented 9 months ago

I'm not quite sure, I see no change on my side.

N-J-Martin commented 9 months ago

The set operators written by @hz66-404 have been added too.

ozgurakgun commented 9 months ago

Thanks both! Is this ready to be merged? Can I ask again for you to check these after we merge them (especially the links).

hz66-404 commented 9 months ago

set operators part is ready, I will double check this after merging them!

hz66-404 commented 9 months ago

The link is working fine!