search

conjure-cp / conjure

Conjure: The Automated Constraint Modelling Tool
Other
94 stars 20 forks source link

Fix original tutorials #622

Closed N-J-Martin closed 7 months ago

N-J-Martin commented 8 months ago

These have been updated to fit with V0.09, not V0.10

ozgurakgun commented 8 months ago

Thanks @N-J-Martin! I left some comments/questions. Also Github thinks the BIBD notebook is "not valid" can you make sure the version in this PR works fine for you?

N-J-Martin commented 8 months ago

Just letting you know I've seen these comments. I'll address them tomorrow.

N-J-Martin commented 8 months ago

Thanks @N-J-Martin! I left some comments/questions. Also Github thinks the BIBD notebook is "not valid" can you make sure the version in this PR works fine for you?

I've readded the notebook, I don't think I resolved the merge conflict properly. It should be fixed now.

ozgurakgun commented 8 months ago

Thanks! The emojis in the BIBD look like the encoded versions of themselves in the diff (they used to just be the emoji versions), not sure what changed there. If you can see the rendered properly in the notebook, it's all fine. See screenshot.

Screenshot 2023-11-18 at 17 46 10

N-J-Martin commented 8 months ago

Thanks! The emojis in the BIBD look like the encoded versions of themselves in the diff (they used to just be the emoji versions), not sure what changed there. If you can see the rendered properly in the notebook, it's all fine. See screenshot.

Screenshot 2023-11-18 at 17 46 10 unfortunately it's like that on the notebook too. I'd hoped that exporting it would fix it! Not sure how to change the encodings back to the emojis without manually changing the output. I presume conjure converted it to work on it.

N-J-Martin commented 8 months ago

Just letting you know I've seen these comments. I'll address them tomorrow.

I believe I've addressed everything. Please let me know if I've missed anything here.