search

conjure-up / spells

conjure-up spells registry
79 stars 37 forks source link

Convert CDK to charms for cloud integration #191

Closed johnsca closed 6 years ago

johnsca commented 6 years ago

Also adds support for GCP in addition to AWS.

johnsca commented 6 years ago

Not tested yet. Wanted to put it up for @hyperbolic2346

johnsca commented 6 years ago

Tested this on AWS (JaaS and bootstrapped controller). On GCE I've hit some issues that seem unrelated (a credential parsing error on JaaS and missing lspci on bootstrapped controller), so I haven't been able to finish a test there.

adam-stokes commented 6 years ago

can i finally merge this?

kwmonroe commented 6 years ago

@johnsca's latest messages look fine:

$ cat canonical-kubernetes/steps/04_enable-cni/before-wait.err
ERROR unrecognized command: juju trust
juju-trust not available; falling back to passing credentials via charm config.
Note: Charm config can be read by anyone with read access to the model.

However, I doubt anyone will actually see them way down in a step .err file. Maybe consider adding a blurb to the cni setResult that warns users about creds being exposed in charm config.