connamara / quickfixn

QuickFIX/n implements the FIX protocol on .NET.
http://quickfixn.org
Other
469 stars 557 forks source link

FieldMap.GetField(XXXField) doesn't return? #20

Closed gbirchmeier closed 12 years ago

gbirchmeier commented 12 years ago

QuickFix.FieldMap.GetField(XXXField) doesn't return anything.

This seems odd. Both QF/C++ and QF/J return stuff. I'm not sure where the precedent came from for our version.

I'm inclined to change them to be more in line with the other ports. Any objections?

gbirchmeier commented 12 years ago

Relevant docs from the ports: http://www.quickfixj.org/quickfixj/javadoc/1.5.0/quickfix/FieldMap.html http://quickfixengine.org/quickfix/doc/html/class_f_i_x_1_1_field_map.html

kennystone commented 12 years ago

Sounds good to me.

gbirchmeier commented 12 years ago

Sounds like Mike is down too (from email exchange).

We'll make that parameter also get returned.