connamara / quickfixn

QuickFIX/n implements the FIX protocol on .NET.
http://quickfixn.org
Other
478 stars 562 forks source link

Consider adding a package icon #861

Closed Rob-Hague closed 4 months ago

Rob-Hague commented 4 months ago

Should make the packages a bit more recognisable/official-looking on nuget.org

Something like this should do it:

diff --git a/QuickFIXn/QuickFix.csproj b/QuickFIXn/QuickFix.csproj
index a5dc869f..eec6b572 100644
--- a/QuickFIXn/QuickFix.csproj
+++ b/QuickFIXn/QuickFix.csproj
@@ -28,11 +28,13 @@
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <PackageReadmeFile>README.md</PackageReadmeFile>
+    <PackageIcon>icon.png</PackageIcon>
   </PropertyGroup>

   <ItemGroup>
     <None Include="..\LICENSE" Pack="true" PackagePath=""/>
     <None Include="..\nuget-enclosures\core-readme.md" Pack="true" PackagePath="README.md" />
+    <None Include="..\icon.png" Pack="true" PackagePath=""/>
   </ItemGroup>

   <ItemGroup>
gbirchmeier commented 4 months ago

You are absolutely right, I will see if we can whip something up for the next release.

Rob-Hague commented 4 months ago

You can also try to reserve the "QuickFIXn" prefix: https://learn.microsoft.com/en-gb/nuget/nuget-org/id-prefix-reservation

gbirchmeier commented 4 months ago

yes, I really ought to do that too, thanks

gbirchmeier commented 4 months ago

Requested the reservation, we'll see what happens