search

connection-lost / LockettePro

LockettePro - A much better Lockette plugin for Bukkit [1.8 - 1.12]
42 stars 59 forks source link

Add support for FactionsUUID #45

Open Maxetto opened 7 years ago

Maxetto commented 7 years ago

not tested

connection-lost commented 7 years ago

Um, I am confused here. What is the relationship between Factions from MassiveCraft and FactionsUUID (https://www.spigotmc.org/resources/factionsuuid.1035/)?

Maxetto commented 7 years ago

FactionsUUID is a fork of the 1.6.x branch from MassiveCraft.

Here's the source code: https://github.com/drtshock/Factions

Maxetto commented 7 years ago

I'm pretty sure this error report (https://pastebin.com/zgqDHc1F) from XxDawnsusxX is due to the use of FactionsUUID (They share the same Plugin Name, since it's a fork as I said).

Also because he asked if the plugin had FactionsUUID support: https://www.spigotmc.org/threads/lockettepro-uuid-support.133105/page-16#post-2423200

connection-lost commented 7 years ago

I will give this a shot.

connection-lost commented 7 years ago

Appreciate your effort, but unfortunately I decide not to support FactionsUUID for now. Supporting two plugins with same plugin name and different package names... too messy. And yet I doubt the effort to maintain FactionUUID support will worth it... Also the plugin itself costs $15 and lack of API documentation... meh... Sorry again for rejecting this pull request.

Maxetto commented 7 years ago

@connection-lost I understand the trouble of supporting two forks of the same plugin. Yet, the plugin is Free if you can build it and many people use that because they like how Factions behaved in 1.6.9.5.

If my fix does work, I suggest you to add it as it's a fire-and-forget addition (FactionsUUID won't likely change anything of their API).