search

connectivedx / Phoenix

http://connectivedx.github.io/Phoenix/
33 stars 5 forks source link

Browserify integration, JS build improvement, Browserify field guide #11

Closed kamsar closed 10 years ago

kamsar commented 10 years ago

This ticket picks up where #7 left off.

I fixed the issues with the base code JS. Then I rejigged the base code to actually use Browserify more properly.

Finally, I wrote a field guide to what Browserify is, how to use it, and how to polyfill regular JS libraries into it.

KAPOW!

ajmueller commented 10 years ago

@kamsar I've added a new file for older versions of IE with an initial requirement of respond.js. The issue with respond.js and Browserify was the IIFE where the window object was passed in as "this," which meant the meaning of "this" was no longer the window object once Browserify was applied to the file. I also split out global.js into a couple files and made slight tweaks elsewhere. This will help keep things a little separate until we can make sweeping architectural changes to separate the constructor from the source code itself.

I'm keeping this PR open for now, though, for one main reason: this will be a big change to how we write JavaScript and we should bring other FEDs up-to-speed first. Let's talk to @stoff and bring this up in the next FED meeting to show everyone. What do you think?

kamsar commented 10 years ago

Sounds good.

ajmueller commented 10 years ago

@kamsar I've added a development branch. I'm going to close this PR since it's set to merge into master. Can you open a new one with a target of development?