Grid System Cleanup - Githubissues

connectivedx / Phoenix

http://connectivedx.github.io/Phoenix/

33 stars 5 forks source link

Closed ajmueller closed 9 years ago

ajmueller commented 9 years ago

Removes push and pull concepts in favor of position.
Position is a 1-indexed value for where a column will appear in the layout (as indicated below).
When position is defined for one element in a "row," then positions must be defined for all elements in that row.
Resolves #134 due to simplification of margin calculations.
Adds optional breakpoint parameter to column mixin. Resolves #81.

ajmueller commented 9 years ago

@elseloop you actually commented on the PR :smile:. I just pushed a change to the wording. Thoughts?

elseloop commented 9 years ago

I feel so...I'm ashamed is what I am. And possibly illiterate.

shame

Anyway, the new wording sounds great. Just top notch. And the commit message? Probably the best in the entire project. :+1:

ajmueller commented 9 years ago

I also just added an optional breakpoint parameter to the column mixin and base grid. Original PR description updated.