search

connectivedx / Phoenix

http://connectivedx.github.io/Phoenix/
33 stars 5 forks source link

Gradient mixin has no direction option #156

Closed drolsen closed 8 years ago

drolsen commented 8 years ago

Our gradient mixin does not have any options to set the direction of the gradient. I've made a new branch "feature/gradient-directions" that now extends a third optional param for direction.

You can use either the four keywords of top, left, bottom and right (with fall-back of bottom), or numerical 45deg values.

Thoughts?

elseloop commented 8 years ago

:+1:

My only note would be to put the new direction parameter into an options map in keeping with the conventions we've got in other mixins. See aspect-ratio for an example.

drolsen commented 8 years ago

Roger

Updated.

elseloop commented 8 years ago

Can you open a PR with your feature branch against development, please?

elseloop commented 8 years ago

Fixed by #159