search

connectivedx / Phoenix

http://connectivedx.github.io/Phoenix/
33 stars 5 forks source link

Sassdoc dependency blocking initial build #157

Open elseloop opened 8 years ago

elseloop commented 8 years ago

Our build scripts do not properly npm install from the sassdoc-theme directory on the very first build after cloning, so any unmet dependencies for Sassdoc throw an error on a first build of Phoenix, without much indication on how to work around it. We have logic in place already in both build.sh and build.cmd that is intended to handle this, but it doesn't appear to be robust enough.

Any help on this one would be much appreciated, as it is a blocking bug in the current release.

//cc @ajmueller @kamsar

ajmueller commented 8 years ago

On which platforms are you having issues with this @elseloop? I tested this fairly thoroughly on Windows and Mac on fresh installs and didn't have any issues. Then again I no next to nothing about shell or Windows bash scripting, so it's likely that there are errors :smile:

jbascue commented 8 years ago

@ajmueller OS X. I was able to replicate the error as well.

ajmueller commented 8 years ago

@jbascue what was the error? It could be something as simple as a write permissions issue in which case adding sudo to the npm install commands in the scripts could fix this.

elseloop commented 8 years ago

After additional attempts on both Windows 8 and OS X, it does appear to be a permissions issue, as @ajmueller suggested from his “new office” on the back nine of some golf course or whatever. I’ll investigate adding sudo to the build scripts...

Just jokes.

ajmueller commented 8 years ago

@elseloop I would never work on the golf course! That's sacrilegious!

P.S. amazing GIF. I want to save that one to my GIF keyboard.

pc-pdx commented 8 years ago

Mee too. I have nothing helpful to add to this conversation. Unless, you .. well, no...