connectivedx / Phoenix

http://connectivedx.github.io/Phoenix/
33 stars 5 forks source link

Changing breakpoints to explicitly state the breakpoint number vs. wo… #163

Closed drolsen closed 8 years ago

drolsen commented 8 years ago

…rds that describe a subjective sizes.

elseloop commented 8 years ago

After sitting with this a bit and reviewing it with some others, I’m not convinced this is a good change for Phoenix or that the mnemonic payoff is worth it. One of the benefits our current breakpoint naming convention allows us is to have abstracted names for breakpoint variables that are decoupled from their values. The biggest benefit I see there is that when one of these breakpoint values change (and they’re necessarily going to change with each project and as development goes on during that project), it can be changed where it’s defined and still make sense everywhere else it’s used. If you no longer have need for breakpoint768 and instead need the breakpoint in that neighborhood to be at 750px instead, you need to define a new breakpoint750 variable and then change everywhere else breakpoint768 was used as well in order for those to make sense/be correct.

I’m going to close this, but feel free to keep the conversation going or reopen if you want. I’m definitely willing to be convinced I’m wrong by the right argument. :hear_no_evil: :smile: