connectivedx / Phoenix

http://connectivedx.github.io/Phoenix/
33 stars 5 forks source link

Update Dependencies for Node v4 #177

Closed ajmueller closed 9 years ago

ajmueller commented 9 years ago

I've noticed a handful of issues with the latest major release of Node and the dependencies being used. Here's a quick breakdown:

I'd put this all in a PR, but I just finished catching all of these issues on one client project and need to hop on a call for another.

elseloop commented 9 years ago

Thanks, @ajmueller! I've been wanting to test this and boom! you beat me to it. I'm hoping to get this all taken care of and out by Friday, should you be bored an looking to write up a PR.

You're the Best

ajmueller commented 9 years ago

You just keep knocking it out of the park with these Bill Murray GIFs.

Nice work

pc-pdx commented 9 years ago

yesyes. i've just grabed a fresh checkout as of yesterday and had to manually copy [ Assets\src\node_modules\gulp-combine-media-queries\node_modules\through2\node_modules\readable-stream ] over from an existing project in order to complete a build. Seems this a known, possible race issue, FWIW.
All that aside, i believe i'm still running node 0.10.33 and as such, this readable-stream issue may be a full-stop blocker (?) - let me know if that warrants a separate ticket as i've found it impossible to build without intervention. tl;dr: reading my tickets

elseloop commented 9 years ago

Fixed in 2.2.0 release