search

connectivedx / Phoenix

http://connectivedx.github.io/Phoenix/
33 stars 5 forks source link

Release 2.2.0 #179

Closed elseloop closed 8 years ago

ajmueller commented 8 years ago

Please check my note on #178. It might be worth waiting for the next minor version of clean-css to get media query combining to work properly.

elseloop commented 8 years ago

Thanks, @ajmueller. I agree, of course, but I think moving ahead with this change is worthwhile anyway. Hear me out:

We pull gulp-combine-media-queries now, let clean-css handle it when that enhancement is released (bumping the required version on that accordingly then), and live with the slightly larger file size in the interim. I've landed there primarily because leaving gulp-combine-media-queries in as it stands breaks the production build and any alternatives I've been able to find—band aids that might hold us over before the next minor release of clean-css—appear to be just as unmaintained/unhelpful as gulp-combine-media-queries. This at least gets us to a clean production build on master today.

I'm going to hold off on merging this in, as I'd like your input (and may circulate it around a bit). Thanks again for throwing up your hands on this.

ajmueller commented 8 years ago

Oh I totally agree; in fact it's what I did with the client where I discovered the issue (removed gulp-combine-media-queries for now and will update gulp-minify-css later), I just wanted to make sure you were fully aware of the issue. Go forth and ignore me!

elseloop commented 8 years ago

Cool. Cool cool cool. GOING FOR IT!

ajmueller commented 8 years ago

I find the lack of an Abed GIF in your previous comment disturbing...I must remedy that.

Cool cool cool