search

connectivedx / Phoenix

http://connectivedx.github.io/Phoenix/
33 stars 5 forks source link

em() and rem() accept lists. #19

Closed justinskolnick closed 10 years ago

justinskolnick commented 10 years ago

Modifies em() and rem() functions to permit Sass lists, i.e., strings of values. Currently shorthand declarations require calling the functions multiple times:

margin: em(12px, 15px) em(18px, 15px) em(9px, 15px);

This update allows devs to pass multiple values in a single call:

margin: em(12px 18px 9px, 15px);

ajmueller commented 10 years ago

@justinskolnick this is an awesome idea! There are a few code conventions I'd like to clean up in the functions themselves and we should add usage of the new feature where applicable in the base source as well.

In the meantime, would you mind closing this pull request and re-opening it with the new base being the development branch? Sorry for the inconvenience, but Github does not allow you to alter an existing pull request's branches and I'd like to really streamline our workflow with a development and master branch.

justinskolnick commented 10 years ago

Closing to move to dev branch.