connectivedx / Phoenix

http://connectivedx.github.io/Phoenix/
33 stars 5 forks source link

License #36

Closed ajmueller closed 9 years ago

ajmueller commented 9 years ago

As we get near release it's a good idea to begin thinking about licensing. Since the project will be open source and is built around open source projects, we need to make sure the licensing is done properly considering any dependencies and libraries we use. I've been careful throughout development to choose code that is openly available, so this shouldn't be an issue, I'd just like to begin a discussion around it and have it organized.

For instance, our grid system is based on Gumby, which has an MIT license, as do Modernizr, Respond, and responsive tabs. We use Fancybox which is licensed with a Creative Commons Attribution non-commercial license. Does anyone know enough about open source projects to know how licensing works with regards to dependencies having different licenses? For instance can we apply an MIT license to the project as a whole and allow the independent dependencies to have their own licensing? Since we have a multi domain license for Fancybox do we need to provide attribution in our code? These are all questions I plan on digging into before launch and if anyone knows answers, please let me know and provide links to evidence.

ajmueller commented 9 years ago

Based on a quick read of the creative commons license for Fancybox it would appear that we can adapt their code (which we have done with the SCSS module), but will need to note that we made changes. Since we've paid for a commercial license for ISITE we can use it on our own projects. The JS file has a link to the license, so I believe we are covered there in terms of use of Fancybox on non-commercial vs. commercial projects. As for attribution, we need to provide "the name of the creator and attribution parties, a copyright notice, a license notice, a disclaimer notice, and a link to the material," all of which except for a disclaimer notice are available if we switch the Fancybox JS file to the unminified version.

justinskolnick commented 9 years ago

As long as the build process minifies dependencies, we're safe to include the unminified Fancybox.

ajmueller commented 9 years ago

That was my thought as well, Justin. We really should just start using unminified libraries for everything. That way we can have clear diffs when we upgrade to new versions of code and catch potential issues like respond always referring to window as this, which messes up Browserify.

jbascue commented 9 years ago

"We really should just start using unminified libraries for everything."

This! Because it will happen that a minified version gets included in a project without its readable counterpart. Granted there are ways for the next developer to get around that but it's inefficient and, might I say, rude.