search

connectivedx / Phoenix

http://connectivedx.github.io/Phoenix/
33 stars 5 forks source link

Mixin Cleanup #47

Closed ajmueller closed 9 years ago

ajmueller commented 9 years ago

Contains code from #46 since it expanded our use of icons. This work replaces some mixins that were a better fit as placeholders.

Closes #40, closes #46, and closes #48.

ajmueller commented 9 years ago

This can lead to issues in IE8 since the selector that is used for custom checkboxes and radio buttons "filters out" IE8 using the :not selector. Essentially this means that IE8 will ignore ALL icon properties since it doesn't recognize some of the selectors in the selector string that's built by using a placeholder instead of a mixin.

I still think this is worth investigating further, but this is definitely not yet ready to merge.

ajmueller commented 9 years ago

As discussed in the FED meeting today, we will keep the "placeholders" name and I will look into fixing the IE8 placeholder issue for Icomoon.

ajmueller commented 9 years ago

I've updated the placeholders for icons in fa9f2b42a86507b531f449fc02ecf841fab50fef. There is now a second placeholder for modern browsers; unfortunately this is the best solution I could come up with unless we want to completely eliminate the usage of :not and rely on a polyfill to enable older browsers to have a "checked" state for radio buttons and checkboxes.

Does anyone have any ideas other than these? I'm all ears.

ajmueller commented 9 years ago

I'm going to merge this and if there is any more cleanup desired, we can fix it later.