search

connectivedx / Phoenix

http://connectivedx.github.io/Phoenix/
33 stars 5 forks source link

Adds a variable for icon font family to variables/typography #60

Closed elseloop closed 10 years ago

elseloop commented 10 years ago

I realize this adds a variable that is longer (by one character) than what it is abstracting, but I found myself wanting it today while working on CTGR. Once literally, in that I used a non-existent variable and was appropriately scolded by gulp. I also looked a couple times today to see if 'iconmoon' was capitalized in the @font-face declaration. My short-term memory could be better, I admit, but having this variable available would (likely) eliminate the need for guessing.

elseloop commented 10 years ago

Ok, now that I've opened this PR, I see that $iconFontFamily exists in base/defaults/_icons.scss. Of course.

So, closing this...

youfeeltheshame

ajmueller commented 10 years ago

This brings up a potential flaw, though, in that it isn't obvious where the $iconFontFamily variable is defined. Originally my thinking was to put it with the icon code to make it more modular, so if you didn't need icons, you'd just remove the entire icon file. Now that Icomoon has become central to our implementations (e.g. checkboxes and radio buttons), perhaps this should be a global variable? Or perhaps the structure of how we use icon fonts should be re-thought?