Windows Karma Fix

[drolsen]

Upon trying to commit with a fresh copy of develop, I was not able to get past Karma now:

After spending quite a bit of time on this, it appears that one of our new modules is causing this Windows only Karma issue.

I tried to resolve the issue by:

• Upgrade to various node versions (no success, reverted back to 8.9.0)
• Upgrade karma one release at a time till latest (no success, reverted back to 1.7.0)
• Upgrade karma-tap one release at a time till latest (no success, reverted back to 3.1.1)
• Downgraded karma-tap to 2.1.4 (SUCCESS!)
• Upgraded karma to latest release (SUCCESS!)

Description

• Upgrades karma to 2.0.0
• Downgrades karma-tap to 2.1.4

Motivation and Context

This resolves karma error for Windows users that would prevent user from being able to commit changes.

How Has This Been Tested?

• delete node_modules folder
• delete package-lock.json
• run npm or yarn install
• run npm or yarn test

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [x] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [x] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [x] All new and existing tests passed.

[bstaruk]

I actually wasn't able to reproduce the original issue (Win10, Node 8.9.4), but I have no issues running build/dev/test commands with your tweaks either so it's all good!

I did notice that the yarn.lock file was removed but not added to the .gitignore, so it regenerates when yarn is run to install dependencies.

Let me know if anything changes and I can help to test again.

[drolsen]

I'm not sure why, but this evening this issue has seemed to resolved its self. I'm going to close this PR, but for legacy purposes I did try the following:

• remove node_modules, package-lock.json, yarn.lock
• ran npm install and yarn install to generate both lock files
• try simple commit to minor file change and issue would occur

I can only assume a dependency out there in our plugin stack got hot patched over the last 24 hours and this now no longer an issue under original karma and karma-tap versions.