connectome-neuprint / neuPrintExplorer

View connectomic data stored in neuPrint
Other
24 stars 4 forks source link

allow full orbiting in the skeleton view #258

Closed hubbardp closed 4 years ago

hubbardp commented 4 years ago

Making an analogy between camera manipulation in the skeleton view and orbiting around the Earth, it is not possible to orbit over the poles. The problem is in SharkViewer, where shark_viewer.js uses the standard THREE.OrbitControls here:

this.trackControls = new OrbitControls(this.camera, this.dom_element);

The limitations of THREE.OrbitControls is evident in its demo code here:

https://threejs.org/examples/#misc_controls_orbit

hubbardp commented 4 years ago

There is a test of a solution running here (temporarily): https://hubbardp-ws1.int.janelia.org:11000

hubbardp commented 4 years ago

Pull request a fix to SharkViewer: https://github.com/JaneliaSciComp/SharkViewer/pull/14

hubbardp commented 4 years ago

Merged.