search

connectrpc / connect-es

The TypeScript implementation of Connect: Protobuf RPC that works.
https://connectrpc.com/
Apache License 2.0
1.38k stars 80 forks source link

Verify our exports with arethetypeswrong #801

Closed timostamm closed 1 year ago

timostamm commented 1 year ago

https://github.com/arethetypeswrong/arethetypeswrong.github.io has been available as a CLI for some time.

Same as https://github.com/bufbuild/protobuf-es/issues/456, we should use it to verify our exports. We need to pick up the work started in https://github.com/bufbuild/protobuf-es/pull/536.

We still populate the main property in our package.json files, which is necessary for Webpack < 5.x (see https://github.com/connectrpc/connect-es/pull/167). We should verify whether it is still necessary.

srikrsna-buf commented 1 year ago

I tried to do this for knit. The latest unreleased version passes the online test without any problems. It also has sub exports similar to the connect package. Could be useful to take a look.

timostamm commented 1 year ago

I tried to do this for knit. The latest unreleased version passes the online test without any problems. It also has sub exports similar to the connect package.

Yes, it's not a big lift to fix reported issues, but I think it's important to understand any issues we fix and nail down a pattern for exports that we can apply to all repositories. The attw CLI then allows us to guard against regressions in CI - but that's only helpful if we have confidence in what issues attw detects and to which ones it is blind.

smaye81 commented 1 year ago

Fixed by #838