search

connectrpc / connect-es

The TypeScript implementation of Connect: Protobuf RPC that works.
https://connectrpc.com/
Apache License 2.0
1.35k stars 76 forks source link

Investigate removing subpath fallback files #839

Open smaye81 opened 1 year ago

smaye81 commented 1 year ago

Currently, we have fallback files in packages/connect for consumers that don't support subpath exports (protocol.js, protocol-connect.js, protocol-grpc.js, and protocol-grpc-web.js).

However, these files may not be needed as it is basically supporting Node.js v10 module resolution. Since Node 10 has been EOL for more than two years, we could potentially remove these altogether.

This could potentially break some bundlers, so we'd have to conduct an investigation into whether we could safely remove them.

For further context, see https://github.com/connectrpc/connect-es/pull/838#issuecomment-1737869511

timostamm commented 5 months ago

We have removed the fallback files in https://github.com/bufbuild/protobuf-es/pull/804. If this does not cause any issues, we can safely do it here as well.

timostamm commented 3 weeks ago

With Parcel and Metro, subpath exports need to be enabled, see https://github.com/bufbuild/protobuf-es/blob/main/MANUAL.md#parcelmetro-fails-to-resolve-imports