search

connectrpc / connect-go

The Go implementation of Connect: Protobuf RPC that works.
https://connectrpc.com
Apache License 2.0
2.92k stars 96 forks source link

Are there plans to provide a standalone prometheus package that works with connect-go? #314

Closed nomad-software closed 2 years ago

nomad-software commented 2 years ago

Is your feature request related to a problem? Please describe. Nope. This isn't directly related to connect-go per se but to other packages made available by bufbuild.

I notice there is a standalone package to implement health checking so I wondered if there were plans to also release a Prometheus package that imitates https://github.com/grpc-ecosystem/go-grpc-prometheus but is created to work with connect-go?

Describe the solution you'd like A drop-in solution similar to https://github.com/bufbuild/connect-grpchealth-go that mimics https://github.com/grpc-ecosystem/go-grpc-prometheus

Describe alternatives you've considered I'd have to write one myself, which is fine but I wondered if you have plans for a more official package?

akshayjshah commented 2 years ago

We're planning to release a standalone OpenCensus integration, but not something that's Prometheus-specific. (If you're not familiar with it, OpenCensus is an abstraction over multiple metrics backends - it supports sending data to Prometheus, DataDog, statsd, Stackdriver, etc.) That package should be a good example for anyone who wants to integrate directly with a different metrics backend.

ETA is a few weeks; it's blocked on #296, which I'm actively working on.

nomad-software commented 2 years ago

Great, thanks for the update.

nomad-software commented 2 years ago

@akshayjshah Have you any more information on the release of the OpenCensus integration please?

akshayjshah commented 2 years ago

Sorry! We're caught up with the upcoming connect-web release. We'll return to OC integration once that's done.

akshayjshah commented 2 years ago

Sorry for the long periods of silence on this issue! Internally, we've decided to switch from OpenCensus to OpenTelemetry 😰 We're still not planning to write a first-party package that integrates directly with Prometheus. I'm going to close this issue in favor of #344 - if you're interested in ready-to-use observability interceptors, please subscribe to that issue instead.

pqn commented 1 year ago

https://github.com/easyCZ/connect-go-prometheus may be relevant here.