conformance: client does not return correct error code for 409 and 415 HTTP status codes

connectrpc / connect-go

The Go implementation of Connect: Protobuf RPC that works.

https://connectrpc.com

Apache License 2.0

2.76k stars 90 forks source link

conformance: client does not return correct error code for 409 and 415 HTTP status codes #747

Closed jhump closed 1 month ago

jhump commented 1 month ago

The spec indicates that a 409 Conflict HTTP status code should be mapped to an aborted RPC error and 415 Unsupported Media Type should be mapped to an internal RPC error.

The client in this repo instead reports unknown RPC error for these cases.

Found by conformance tests in v1.14.0.

jhump commented 1 month ago

This bug was fixed by #673, and the fix was released in v1.15.0.

Also note that the specification was subsequently revised by RFC 003, which changed the mappings for these two and several other codes. Those changes were implemented in #706 and released in v1.16.0.