search

connectrpc / connect-go

The Go implementation of Connect: Protobuf RPC that works.
https://connectrpc.com
Apache License 2.0
2.95k stars 96 forks source link

Decide whether to send & accept Grpc-Timeout for Twirp #9

Closed akshayjshah closed 2 years ago

akshayjshah commented 3 years ago

The current Twirp maintainers aren't interested in adding timeouts to the wire protocol (see twitchtv/twirp#329). They've done a remarkably good job keeping the protocol tiny, so I'm not surprised.

Currently, reRPC servers respect the Grpc-Timeout header, even when the content-type indicates that the client is using the Twirp protocol. This seems relatively harmless, but perhaps we should stick to the minimal spec and drop this support?

akshayjshah commented 2 years ago

Irrelevant, since we're dropping Twirp support - it doesn't meet many of our goals for a simpler, browser-friendly protocol.