Closed hirasawayuki closed 3 months ago
vercel[bot]
commented
4 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| connect | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 18, 2024 9:45pm |
CLAassistant
commented
4 months ago
All committers have signed the CLA.
hirasawayuki
commented
4 months ago @pkwarren Thank you for your review! Based on your feedback, I've made revisions in commit 43c78d7.
Unified the documentation for using ElizaService across Node, Kotlin, and Swift as much as possible. Could you please review it again?
pkwarren
commented
4 months ago Thank you for your review! Based on your feedback, I've made revisions in commit 43c78d7.
Thank you so much for making the updates. I will look first thing on Tuesday when we get back from a holiday weekend.
If there are small tweaks to the docs are you ok with me making edits in this PR?
hirasawayuki
commented
4 months ago If there are small tweaks to the docs are you ok with me making edits in this PR?
Sure, feel free to make any edits. Thank you!
nicksnyder
commented
3 months ago Hi @hirasawayuki, there are some other changes we want to make to this PR before merging, but it is going to be more efficient if you allow us to push directly rather than going back and forth on PR comments. Can you configure your fork to allow edits from maintainers?
Edit: nevermind you already have it configured correctly. Just got confused because the person who was trying to push a change wasn't a maintainer.
The Buf CLI 1.32.0 introduced a v2 config format for buf.gen.yaml (blog post). This PR updates the examples in documentation to use buf.gen.yaml v2 for generating code.