Update RN polyfill instructions to use fewer & newer polyfills

connectrpc / connectrpc.com

Docs, governance, and RFCs for Connect: Protobuf RPC that works.

https://connectrpc.com

Apache License 2.0

15 stars 18 forks source link

Update RN polyfill instructions to use fewer & newer polyfills #182

Closed ryanlntn closed 1 week ago

ryanlntn commented 3 weeks ago

The current RN documentation suggests using react-native-polyfill-globals which has not been updated in a few years. There have also been recent updates to RN negating the need for many of those polyfills. This PR updates the instructions to use a minimal number of newer and better maintained polyfills.

Some highlights:

Drops react-native-polyfill-globals in favor of using RN's polyfillGlobal directly.
Drops atob and btoa polyfills since hermes is now the default and includes atob and btoa.
Replaces unmaintained text-encoding with maintained and more performant react-native-fast-encoder. (Note that hermes does include TextEncoder but not yet TextDecoder)

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
connect	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 17, 2024 1:40pm

smaye81 commented 3 weeks ago

Hi @ryanlntn. We've been trying to test out these docs changes in our examples repo, but we are running into issues making things work. It's a fun game of whack-a-mole trying to get the correct things polyfilled with various versions of dependencies.

We have a PR that we've started here which attempts to follow the docs. Would you be willing to move this one across the finish line based on your suggestions? Basically if the following all pass in that example project, we should be good:

npm run ci
npm start (and then confirming you are able to run the app on a device)
npm run web (and able to run in a browser)

ryanlntn commented 2 weeks ago

Hey @smaye81!

No problem. I opened a PR to update the update here.