search

connectrpc / connectrpc.com

Docs, governance, and RFCs for Connect: Protobuf RPC that works.
https://connectrpc.com
Apache License 2.0
15 stars 19 forks source link

Document guidelines for Developer Certificate of Origin #183

Closed timostamm closed 2 months ago

timostamm commented 3 months ago

We want to satisfy the CNCF's DCO guidelines, and run the GitHub app DCO on all pull requests.

However, we've had the case where a user signed with his E-Mail address, but DCO expected the commit to be signed with their GitHub-generated no-reply address. We should investigate the cause, and provide helpful guidelines.

This should be implemented as a short section in the contributing.md file of each connectrpc repository.

timostamm commented 2 months ago

I wasn't able to reproduce the issue - tested in https://github.com/connectrpc/connect-es/pull/1139. My commits pass the DCO check when I sign with git commit -s without any issues. The DCO check actually gave helpful tips. IMO we should let users know in advance to sign with -s in CONTRIBUTING.md.

timostamm commented 2 months ago

Fixed by https://github.com/connectrpc/connectrpc.com/pull/184, and similar commits on other repositories.