search

connectrpc / connectrpc.com

Docs, governance, and RFCs for Connect: Protobuf RPC that works.
https://connectrpc.com
Apache License 2.0
15 stars 19 forks source link

Add a section about CORS #93

Closed timostamm closed 9 months ago

timostamm commented 10 months ago

Closes https://github.com/connectrpc/connectrpc.com/issues/42.

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connect ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 9:32am
timostamm commented 9 months ago

Thanks for the comments! Updated.

We should link to the overall CORS page early,

Certainly a good idea 😆.

and we should link directly to the default header safelists.

Linking to safelisted response headers in https://github.com/connectrpc/connectrpc.com/pull/93/commits/449c4770291616faf85f4cfacef881f2f83a0be4.

Will it actually be helpful to link to to safelisted request headers? Content-Type is listed there, but it's quite easy to miss the extremely limiting restrictions.

akshayjshah commented 9 months ago

and we should link directly to the default header safelists.

Linking to safelisted response headers in 449c477.

Will it actually be helpful to link to to safelisted request headers? Content-Type is listed there, but it's quite easy to miss the extremely limiting restrictions.

Fair enough. I'm happy with the links as you've proposed them :)