search

connectrpc / otelconnect-go

OpenTelemetry tracing and metrics for Connect.
https://connectrpc.com
Apache License 2.0
127 stars 29 forks source link

Adhere to gRPC error code statuses #122

Closed joshcarp closed 10 months ago

joshcarp commented 1 year ago

https://github.com/open-telemetry/opentelemetry-specification/pull/3333 introduced a breaking change to the OpenTelemetry semantic conventions for gRPC so this should be implemented

joshcarp commented 1 year ago
gRPC Status Code SpanKind.SERVER Span Status SpanKind.CLIENT Span Status
OK unset unset
CANCELLED unset Error
UNKNOWN Error Error
INVALID_ARGUMENT unset Error
DEADLINE_EXCEEDED Error Error
NOT_FOUND unset Error
ALREADY_EXISTS unset Error
PERMISSION_DENIED unset Error
RESOURCE_EXHAUSTED unset Error
FAILED_PRECONDITION unset Error
ABORTED unset Error
OUT_OF_RANGE unset Error
UNIMPLEMENTED Error Error
INTERNAL Error Error
UNAVAILABLE Error Error
DATA_LOSS Error Error
UNAUTHENTICATED unset Error
dragon3 commented 1 year ago

Hi, I've just created a pull request to fix this issue 👉 https://github.com/connectrpc/otelconnect-go/pull/144

Please take a look when you get a chance 🙏 Thank you!