search

connectrpc / vanguard-go

Support REST, gRPC, gRPC-Web, and Connect clients with one server.
https://pkg.go.dev/connectrpc.com/vanguard
Apache License 2.0
236 stars 14 forks source link

trailers are not being passed correctly in the response #139

Open rauanmayemir opened 1 month ago

rauanmayemir commented 1 month ago

Trailers are being broken in the response when grpc is served behind vanguard:

image

I'm assuming that under the hood vanguard essentially wraps grpcServer.ServeHttp which leads to the same outcome when used as is without vanguard. There is a similar issue that was never really solved: https://github.com/grpc/grpc-go/issues/2206.

emcfarlane commented 1 month ago

@rauanmayemir thanks for raising the issue. I'm going to add the conformance test suite to improve coverage which will hopefully highlight this issue and allow us to investigate solutions. Issues https://github.com/grpc/grpc-go/issues/2206 and https://github.com/grpc/grpc-go/issues/553 look like the cause so ideally we could upstream a fix if we are unable to workaround it.