tier5/test4: Timing, test suite issues, number of checks

[flacks]

1. Timing - Test 4 of tier 5 expects 'carousel-item active' to exist almost always before it is loaded (assertTrue(checkElements())). The test as is has worked about once every 20 tries.
2. Test suite issues - Since test 4 is checking for IDs of the flashcards that the carousel is bound to also have, which causes ID conflicts, I've added a new function for a Revassess taker to fill out, similar to function manipDom() that is required in index.js - function carousel() - so that the carousel can be injected into the DOM only when the fourth test is run. There may be a better solution than this, however.
3. Number of checks - The test currently only checks for 2 out of the 3 flashcards.

I've resolved the issues with the following changes:

diff --git a/RevassessTier3/src/test/java/com/tier5/answers/Answer4Tests.java b/RevassessTier3/src/test/java/com/tier5/answers/Answer4Tests.java
index 6dafbf0..6e95ac4 100644
--- a/RevassessTier3/src/test/java/com/tier5/answers/Answer4Tests.java
+++ b/RevassessTier3/src/test/java/com/tier5/answers/Answer4Tests.java
@@ -12,11 +12,14 @@ import java.util.Map;
 import org.junit.Before;
 import org.junit.Test;
 import org.openqa.selenium.By;
+import org.openqa.selenium.JavascriptExecutor;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
 import org.openqa.selenium.firefox.FirefoxDriver;

 import junit.framework.AssertionFailedError;
+import org.openqa.selenium.support.ui.ExpectedConditions;
+import org.openqa.selenium.support.ui.WebDriverWait;

 import static com.tier5.answers.PointsTests.addPoints;

@@ -64,15 +67,15 @@ public class Answer4Tests {

     @Test
     public void testCarousel() throws InterruptedException {
-        assertTrue(checkElements());
-        for(int i = 0; i<2; i++){
-            next();
-            // new WebDriverWait(wd, 3).until(ExpectedConditions.visibilityOf(wd.findElement(By.xpath("//*[@class='carousel-item active']"))));
+        ((JavascriptExecutor)wd).executeScript("carousel()");
+
+        for (int i = 0; i < 3; i++) {
             Thread.sleep(3000);
             assertTrue(checkElements());
+            next();
         }
+
         addPoints(40);
-
     }

     private Map<String, String> refreshElements(){

The changes were committed here.

[connellrobert]

1. timing has been resolved. The issue was waiting for the carousel to appear and the test was moving forward before the js was finished working. I add a Thread.sleep() method call in the before method to allow this to work.
2. Some associates are going to be using HTML for their carousel and use js to manipulate the dom with js. So adding a carousel method to the template isn't ideal. for your code, I recommend calling the carousel function either inside the callFlashcardApi function, or adding an additional onload event listener to the window.
3. there was an assertion before the for loop to check the elements before the loop began. I did change it that way it was easier to read following your recommendations. I am going to close this issue, let me know if there are any more problems.