connell-class / revassess

this is a trial repo for making a template for the revature assessment
2 stars 11 forks source link

Tier 2 SQL statements fail if ended with a semicolon #49

Closed tbiaglow closed 4 years ago

tbiaglow commented 4 years ago

Describe the bug Using OracleSQL, I found that my SQL statements in tier 2 failed if I ended them with a semicolon. For example, the statement:

insert into app_user (user_id, username, password, first_name, last_name, role_id) values (100, 'testuser', 'password', 'Bob', 'Smith', 4)

will pass. However, the statement:

insert into app_user (user_id, username, password, first_name, last_name, role_id) values (100, 'testuser', 'password', 'Bob', 'Smith', 4);

will not pass.

Since the purpose of this tier of Revassess is to gauge students' ability to accurately write DML, the tests should not fail when a semicolon is included at the end of the statement.

To Reproduce Steps to reproduce the behavior: Generate a repository from the template repository. In git bash change the directory to a desired location for cloning the repository to. In git bash clone the generated repository in the desired repository. In git bash cd into the cloned repository. (complete tier1 questions) In git bash checkout the tier2 branch. Add the database credentials for the Oraclesql Database to the setup.properties file. Make sure that the following query is in the answer2.sql file:

insert into app_user (user_id, username, password, first_name, last_name, role_id) values (100, 'testuser', 'password', 'Bob', 'Smith', 4);

Expected behavior The test should pass when a semicolon is used at the end of the SQL statement.

Desktop (please complete the following information):

connellrobert commented 4 years ago

fixed in v2 version